Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update description Add (restart required) #20006

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update description Add (restart required) #20006

wants to merge 4 commits into from

Conversation

HellAholic
Copy link
Contributor

@HellAholic HellAholic mentioned this pull request Dec 7, 2024
Open
@HellAholic HellAholic added the PR: Community Contribution 👑 Community Contribution PR's label Dec 7, 2024
@HellAholic HellAholic mentioned this pull request Dec 7, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2024

Test Results

23 370 tests   23 248 ✅  54s ⏱️
     1 suites       2 💤
     1 files       120 ❌

For more details on these failures, see this check.

Results for commit 30205e1.

@HellAholic
Copy link
Contributor Author

Tests failed due to the issue with the PR for Voron 2 (setting version). Not related to changes in this PR

@HellAholic
update label for clarity
d8b3e77 
Greg's proposal:
add details to clarify what the Y min & Y max refer to
@HellAholic
Update machine head & fan polygon description
4c686af 
Greg's proposal:
add details to clarify what the Y min & Y max refer to.

Previous description was unclear and referred to front of print head as being a negative value which is not accurate.
@HellAholic
Copy link
Contributor Author

@GregValiant added your proposal here in the same PR ☝️

@GregValiant
Copy link
Collaborator

Thanks for the help with both Rotate and Translate.
I've been using Cura for going on 5 years and I'd never noticed that the "Machine head with fans polygon" description has always been wrong. That was certainly adding to the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rburema rburema rburema approved these changes

Assignees
No one assigned
Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HellAholic @GregValiant @rburema